[ 
https://issues.apache.org/jira/browse/JCR-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529341
 ] 

Thomas Mueller commented on JCR-1138:
-------------------------------------

Hi,

The patch looks good. I tried with PostgreSQL and got this problem:

ConnectionRecoveryManager: could not setup connection, reason: could not load 
driver: org.postgresql.Driver, state/code: null/0 
(ConnectionRecoveryManager.java, line 430)
ConnectionRecoveryManager: blocking until database connection is up again... 
(ConnectionRecoveryManager.java, line 368)

Do you agree that retry doesn't make sense if the driver could not be loaded? 
If yes I will change the code. Also, it would probably make sense to write the 
database URL and the user name (not the password) to the log file, so the 
person (alias poor guy) who has to start the database knows which one and can 
test the connection using some other tool.

Thomas

> Data store garbage collection
> -----------------------------
>
>                 Key: JCR-1138
>                 URL: https://issues.apache.org/jira/browse/JCR-1138
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>
> Currently the data store garbage collection needs to be run manually. It 
> should be simpler to use (maybe tool based), or automatic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to