[ 
https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535282
 ] 

Jukka Zitting commented on JCR-996:
-----------------------------------

+1, the patch looks good to me

PS. I'd like to go further to a design where the SPI client wouldn't 
necessarily need to parse the names and paths before passing them down to the 
SPI implementation, but this is already a good step forward and it's probably 
best not to overlay such design changes on top of the proposed restructuring.

> Name and Path interfaces in SPI
> -------------------------------
>
>                 Key: JCR-996
>                 URL: https://issues.apache.org/jira/browse/JCR-996
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: SPI
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>         Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, 
> JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in 
> jackrabbit-jcr-commons. Architecturally it would be better to have Name and 
> Path interfaces in the SPI package, and have the implementing classes in 
> commons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to