[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539341
]
Thomas Mueller commented on JCR-1154:
-------------------------------------
Hi,
Thanks again for the patch! And sorry for the delay. I have a few remarks and
questions:
- please use spaces, not tabs (Jackrabbit consistently uses spaces)
- please don't use import ...*
- byte b[] > byte[] b
- public is not required in interfaces
- return does not require (..)
To fix such problems, I use Checkstyle. If you like I can post the
configuration I use.
Garbage collection: I like make garbage collection implementation independent;
is it OK for you if I remove those cases? AbstractGarbageCollector and
AbstractDataStore are not required then (anyway they are small).
It would be great if the database data store would automatically re-connect if
the connection was lost (important for MySQL). To achieve this,
org.apache.jackrabbit.core.persistence.bundle.util.ConnectionRecoveryManager
can be used.
It's quite tricky that DatabaseRecord extends FilterInputStream... However I'm
not sure if it is required, is it not possible to just wrap the database BLOB
object?
I don't think that FileDataStoreConstants is required.
Those are just my view, and I'm open to discuss them of course.
If you have time to change it yourself please go ahead. Otherwise I will do it
and post the patch here before I commit it - but it will take a few more days.
Thanks for your help!
Thomas
> Database Data Store
> -------------------
>
> Key: JCR-1154
> URL: https://issues.apache.org/jira/browse/JCR-1154
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jackrabbit-core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Blocker
> Fix For: 1.4
>
> Attachments: jr-1.3.1-bea.zip
>
>
> We want to have a database backed data store implementation.
> An implementation using files is already available as part of JCR-926.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
