Jukka Zitting wrote:
Hi,
On 11/1/07, Julian Reschke <[EMAIL PROTECTED]> wrote:
Proposal: document that getEvents only needs to accept EventFilter
objects created by the same SPI implementation for the same SessionInfo
(this reflects reality in JCR2SPI)
+1 There's no guarantee that a remote implementation can deserialize
foreign EventFilters.
That's already part of the Javadoc. The change I want to make is that
it's also bound to a specific SessionInfo.
Proposal: remove special case in getEvents for EventFilter array being null.
+1 One can achieve the same result using a catchall EventFilter.
And it seems JCR2SPI is doing that already.
These changes will allow the SPI implementation to early filter internal
events, even before getEvents() gets called.
Nice.
Question: do we expect many cases in which a client stops listening for
events, but keeps the JCR session open? In this case it might be good if
we could indicate that an EventFilter is not going to be used anymore,
for instance using a dispose() method.
I guess that's a relatively rare use case, so I'd just ignore it for simplicity.
BR,
Jukka Zitting
Thanks for the feedback,
Julian
