[
https://issues.apache.org/jira/browse/JCR-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546499
]
Jukka Zitting commented on JCR-948:
-----------------------------------
Nice, I like it!
Comments:
* It's better if you commit the typo fixes to MySQL and Oracle persistence
managers in a separate "typos" revision
* Even though it's not strictly related, I'd wrap the Derby workaround
d.newInstance() into a try-catch block that simply ignores all exceptions.
AFAIK there's no requirement that a JDBC driver class has a public default
constructor.
> Support for JNDI configuration of BundleDbPersistenceManager
> ------------------------------------------------------------
>
> Key: JCR-948
> URL: https://issues.apache.org/jira/browse/JCR-948
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Miguel Angel Jiménez Sampedro
> Priority: Minor
> Fix For: 1.4
>
> Attachments: JCR-948-patch.txt, jndi.patch
>
>
> It would be nice to have the option to configure BundleDbPersistenceManager
> database specifying a JNDI name of a DataSource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
