[ 
https://issues.apache.org/jira/browse/JCR-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547618
 ] 

Ard Schrijvers commented on JCR-1251:
-------------------------------------

By the way: do not think you should commit the patch like it is now : 
Arrays.copyOf is not supported for java < 1.6. Use System.arraycopy.

Furthermore, I have tested as well, and performance gain is indeed very large! 
Nice improvement!

> DescendantSelfAxisQuery creates too many object instances
> ---------------------------------------------------------
>
>                 Key: JCR-1251
>                 URL: https://issues.apache.org/jira/browse/JCR-1251
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, query
>            Reporter: Christoph Kiehl
>            Assignee: Christoph Kiehl
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: DescendantSelfAxisQuery-patch.txt
>
>
> In DescendantSelfAxisQuery.DescendantSelfAxisScorer.isValid() there is an 
> ArrayList and an Integer instance created on every call. Since this method 
> gets called really often during queries the object creation/gc affects 
> performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to