[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550996
]
Esteban Franqueiro commented on JCR-1154:
-----------------------------------------
I see you have updated the impl. I'm checkin it out right now. I have a few
comments:
* you have to update the javadoc in DbDataStore (it has a wrong package and
class name, an also the className attribute should be "class"
* you left the @author tag in Pool and TempFileInputStream classes
* shouldn't be better to use a larger buffer
inTempFileInputStream.writeToFileAndClose()? like 64K perhaps?
* what happens if two clients request the same binary at the same time? I guess
the temp file doesn't overwrite the other one, so the file is copied twice,
right?
BTW, thanks for commiting the changes I asked for, but I still think that
making RepositoryImpl.getWorkspaceNames() public will be useful (I'm using it
for the GC).
Regards
> Database Data Store
> -------------------
>
> Key: JCR-1154
> URL: https://issues.apache.org/jira/browse/JCR-1154
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jackrabbit-core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Blocker
> Fix For: 1.4
>
> Attachments: jr-1.3.1-bea.zip
>
>
> We want to have a database backed data store implementation.
> An implementation using files is already available as part of JCR-926.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
