Re: jcr2spi spi2dav Sending large data, WorkspaceManager forgets exception

[Jozef Wagner]

Hi,

it's the method near the end of the file:

http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/WorkspaceManager.java?view=markup

it is thrown by service.submit(batch); and it is constraint exception,
about not supplying all required properties.

 private void execute(ChangeLog changeLog) throws RepositoryException,
ConstraintViolationException, AccessDeniedException,
ItemExistsException, NoSuchNodeTypeException,
UnsupportedRepositoryOperationException, VersionException {
            try {
                ItemState target = changeLog.getTarget();
                batch = service.createBatch(sessionInfo, target.getId());
                Iterator it = changeLog.getOperations();
                while (it.hasNext()) {
                    Operation op = (Operation) it.next();
                    log.debug("executing " + op.getName());
                    op.accept(this);
                }
            } finally {
                if (batch != null) {
                    service.submit(batch);
                    // reset batch field
                    batch = null;
                }
            }
        }

Best,
Jozef

On 1/8/08, Marcel Reutegger <[EMAIL PROTECTED]> wrote:
> Hi Jozef,
>
> Jozef Wagner wrote:
> > Problem 1:
> >
> > org.apache.jackrabbit.jcr2spi.WorkspaceManager.execute(ChangeLog changelog)
> > has try{} finally{} block without catch.
> > It happened to me that both try and finally block thrown an exception.
> > Of course exception from try{} was lost, and I got misleaded :)
>
> what kind of exception was thrown in the finally block?
>
>          try {
>              new OperationVisitorImpl(sessionInfo).execute(changes);
>              changes.persisted();
>          } finally {
>              updateSync.release();
>          }
>
> Sync.release() does not declare any exceptions.
>
> regards
>   marcel
>