[
https://issues.apache.org/jira/browse/JCR-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting updated JCR-1304:
-------------------------------
Attachment: JCR-1304.patch
Good point about the workspace config, the attached updated version of my patch
addresses this.
Text.replaceVariables is probably not used elsewhere within Jackrabbit, but I'd
still be wary of changing the API. The current API is clean and simple and a
client can trivially include (or exclude) system properties in the set of
properties being replaced.
> Support system properties in ${...} vars in XML config files
> ------------------------------------------------------------
>
> Key: JCR-1304
> URL: https://issues.apache.org/jira/browse/JCR-1304
> Project: Jackrabbit
> Issue Type: New Feature
> Components: config, jackrabbit-jcr-commons
> Affects Versions: 1.3.3, 1.4, 1.5
> Reporter: Alexander Klimetschek
> Attachments: enable-system-props-in-config-vars.patch,
> JCR-1304.patch, JCR-1304.patch
>
>
> The variable replacement (${...}) in config files like repository.xml
> currently only allows for the special variables introduced by Jackrabbit, eg.
> ${wsp.name} or ${rep.home}. But it would be useful to support all java system
> properties here as it is some kind of a standard in Java XML config files
> (see Spring for an example).
> This makes it easier to inject variables from outside the config file, eg. by
> setting them on the command line or injecting them programmatically in test
> cases. Typical parameters for that include database connection credentials,
> which one wants to avoid to put into repository.xml files that are often
> checked into SVN.
> This is especially true for test cases, eg. I currently work on a persistence
> manager component and I want to include the repository.xml in the source tree
> (under applications/test) but without my specific credentials. These are
> applied by loading a user-specific properties file through the test case
> before the repository is started and the config is read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
