Re: svn commit: r613799 - /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java

[Jukka Zitting]

Hi,

On Jan 21, 2008 10:48 AM,  <[EMAIL PROTECTED]> wrote:
> if (isNullOrEmpty(user) && isNullOrEmpty(password)) {

Minor nit, I would rather use only null checks, as in:

    if (user == null && password == null) {

This way there is the option for someone to explicitly invoke
ds.getConnection("", "") instead of ds.getConnection():

   <param name="user" value=""/>
   <param name="password" value=""/>

Also, from the design perspective null, not "", is used to mark
unspecified configuration options.

BR,

Jukka Zitting