[
https://issues.apache.org/jira/browse/JCR-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561314#action_12561314
]
Jukka Zitting commented on JCR-1331:
------------------------------------
> Name, NamespaceResolver and NamePathResolver.
My patch replaces all those dependencies with code like the following:
session.getNamespacePrefix("http://www.jcp.org/jcr/mix/1.0";) + ":lockable"
After that change the Lockable class only depends on the JCR API and should be
just fine in jcr-commons. Most notably it meets the criteria defined in [1]:
"The jackrabbit-jcr-commons package should contain generic utility
classes that work *on top of* the JCR API. The classes should handle
names and paths in string format, and use the namespace methods on
javax.jcr.Session where name manipulation is needed."
> apart from that, there was no reason... and i don't have any strong feeling
> for
> the Locked class in particular nor about it's position in the code.
OK, thanks. Unless anyone has further objections I'll re-commit the patch in a
few days time.
[1] http://www.mail-archive.com/[email protected]/msg06698.html
> Inproper deprecation of Locked class
> ------------------------------------
>
> Key: JCR-1331
> URL: https://issues.apache.org/jira/browse/JCR-1331
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-commons
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Jukka Zitting
> Fix For: 1.4.1
>
> Attachments: JCR-1331.patch
>
>
> The Locked class in the jcr-commons package has been deprecated with 1.4 and
> moved to the spi-commons.
> However as this is a common class which does not depend on the spi, it should
> rather stay in jcr-commons.
> The dependencies to spi can simply be removed again.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
