Marcel Reutegger wrote:
Jukka Zitting wrote:
- move it into jackrabbit-spi-commons.
+1 to moving it to jackrabbit-spi-commons.
+1
On the other hand, I can think of a few reasons for not doing that now,
such as:
- exposing the internal query tree as a "public" API may be problematic.
I wouldn't worry too much about those. We can label the query parser
in spi-commons so that people don't expect the API to be too stable. I
don't see any problems in making the query tree public.
the classes are already now partially public and developers use them ;)
OK,
so next steps could be:
- open JIRA issue
- duplicate source and build infrastructure from o.a.j.core.query to
o.a.j.spi.commons.query, deprecate the old stuff
- switch over jackrabbit.core to use spi-commons for query
- remove the old code
- optimally, add specific test cases for the query tree generation.
BR, Julian
