[ 
https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565982#action_12565982
 ] 

Chris Schmidt commented on JCR-1362:
------------------------------------

More of a refactoring request, but could the code that handles DB interaction 
be extracted to a common utility class (or set of classes)?  The current 
implementation violates the DRY principle and could cause additional 
maintenance issues in the future.

> DatabaseJournal improperly finds tables in external schemas when used on 
> Oracle
> -------------------------------------------------------------------------------
>
>                 Key: JCR-1362
>                 URL: https://issues.apache.org/jira/browse/JCR-1362
>             Project: Jackrabbit
>          Issue Type: Bug
>    Affects Versions: 1.3.3, 1.4
>            Reporter: Chris Schmidt
>
> The DatabaseJournal currently calls database metadata to determine if the 
> journal table has already been created.  It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema 
> on the same database.  Other DBMS code within JackRabbit has a specific 
> Oracle version that handles this case.  In order for the journal table to be 
> properly created, Oracle databases will need the schema name included in the 
> getTables() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to