[ 
https://issues.apache.org/jira/browse/JCR-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela resolved JCR-1391.
-------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.4.1)
                   1.5
         Assignee: angela

applied patch as is. thanks for finding this (and for the patch).
angela

> [PATCH] remove minor unneeded code stutter
> ------------------------------------------
>
>                 Key: JCR-1391
>                 URL: https://issues.apache.org/jira/browse/JCR-1391
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>    Affects Versions: 1.4
>            Reporter: Dave Brosius
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: remove_stutter.patch
>
>
> Code has a repeated method call on isOrderable for no reason as such
> {code}
> public String getSupportedMethods() {
>         String ms = super.getSupportedMethods();
>         if (isOrderable()) {
>             StringBuffer sb = new StringBuffer(ms);
>             // Ordering
>             if (isOrderable()) {
>                 sb.append(", ").append(OrderingResource.METHODS);
>             }
>             return sb.toString();
>         } else {
>             return ms;
>         }
>     }
> {code}
> patch cleans this up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to