[ 
https://issues.apache.org/jira/browse/JCR-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572828#action_12572828
 ] 

Tobias Bocanegra commented on JCR-1424:
---------------------------------------

i agree for the integer etc. conversions but not for the boolean. since there 
is only the TRUE and FALSE boolean object which are static and never create new 
tmp objects.

> [PATCH] simplify conversion of strings to primitives by using parseXXX, not 
> valueOf(xxx).xxxValue()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1424
>                 URL: https://issues.apache.org/jira/browse/JCR-1424
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: core 1.4.2
>
>         Attachments: simplify_string_to_primitive.patch, 
> simplify_string_to_primitive.patch
>
>
> Code converts strings to primitives using a two step process, eg
> Boolean.valueOf(myString).booleanValue();
> can be simplified to 
> Boolean.parseBoolean(myString);
> true of Float, Double, Int etc. 
> In some cases, this avoids allocating temporary boxed objects
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to