[ 
https://issues.apache.org/jira/browse/JCR-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572951#action_12572951
 ] 

Alexander Klimetschek commented on JCR-1423:
--------------------------------------------

clone() will copy the object at hand with the correct type - the caller doesn't 
have to know the exact subclass of the object. With a copy constructor, the 
client has to know the exact type.

Both can be combined; a typical implementation calls the (correct) copy 
constructor from the clone() method.

> [PATCH] fix clone implementation
> --------------------------------
>
>                 Key: JCR-1423
>                 URL: https://issues.apache.org/jira/browse/JCR-1423
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr2spi
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: fix_clone_impl.patch
>
>
> Several classes implement clone, by doing new XXXX() to create the object. As 
> these classes aren't final, this will fail if these classes are ever derived 
> from (which they are not, right now). The correct implementation is to call 
> super.clone(). This patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to