[
https://issues.apache.org/jira/browse/JCR-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577900#action_12577900
]
Jukka Zitting commented on JCR-1233:
------------------------------------
Side note: IMHO for code to look good in code quality tools is or at least
should be equivalent to good programming style. If not, then there's something
wrong with the tools. :-)
As for why I think moving the Ids to a separate package is especially important
for code quality tools: as long as they are in o.a.j.core many tools have
trouble identifying circular dependencies and other design issues beyond the
obvious o.a.j.core.foo -> o.a.j.core dependencies caused by the Id classes.
Creating o.a.j.core.id will not solve those issues, but will at least make them
more visible and thus easier to solve.
> Create org.apache.jackrabbit.core.id
> ------------------------------------
>
> Key: JCR-1233
> URL: https://issues.apache.org/jira/browse/JCR-1233
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Jukka Zitting
> Priority: Minor
>
> I'd like to create a separate package for the identifier interfaces and
> classes in jackrabbit-core. Currently all the identifiers are in
> org.apache.jackrabbit.core, which makes almost all the other packages have
> dependencies to o.a.j.core and causes trouble for various package-level code
> quality and dependency analysis tools.
> For now the package would contain the ItemId, NodeId, and PropertyId classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
