[
https://issues.apache.org/jira/browse/JCR-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587115#action_12587115
]
Stefan Guggisberg commented on JCR-1526:
----------------------------------------
thanks, michi!
i quickly browsed through the patch, looks good.
however, i've got one minor issue:
if i interpret the code changes in PathFactoryImpl$Path#getNormalizedPath()
correctly the following call would succeed where it currently throws an
exception:
NameResolver nameResolver = ...
PathResolver pathResolver = new
ParsingPathResolver(PathFactoryImpl.getInstance(),
nameResolver);
...
pathResolver.getQPath("/..").getNormalizedPath();
according to the javadoc of Path#getNormalizedPath it should throw an exception.
furthermore, i might be wrong but i think that it is still possible to create
syntactically incorrect paths using PathFactoryImpl (JCR-1409), e.g.
PathFactory pf = PathFactoryImpl.getInstance();
Path.Element re = pf.getRootElement();
Path illegalPath = pf.create(new Path.Element[]{re, re});
i would expect that Path objects always represent syntactically correct paths.
> Various improvment to Path and PathImpl
> ---------------------------------------
>
> Key: JCR-1526
> URL: https://issues.apache.org/jira/browse/JCR-1526
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi, jackrabbit-spi-commons
> Reporter: Michael Dürig
> Attachments: JCR-1526.patch
>
>
> There are various issues with Path and PathImpl which the following patch
> addresses:
> - Fixed problem with normalization of some paths in PathImpl.
> - Fixed handling of relative paths in PathImpl.
> - Fixed wrong return value for depth and ancestor count in PathImpl.
> - Added method for determining equivalence of paths in PathImpl.
> - Fixed subPath method in PathImpl.
> - Clarified blurry contract for Path.
> - Added many new test cases
> For many of the fixes credits are due to Angela.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
