[ 
https://issues.apache.org/jira/browse/JCR-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590197#action_12590197
 ] 

Esteban Franqueiro commented on JCR-1525:
-----------------------------------------

I'm working on this refactoring and I ended up with an empty 
Oracle10R2FileSystem. From a code point of view this class should be removed, 
but from a user's perspective, I think its more clear to have a class with a 
more accurate name.
The other possibility is to rename the already mentioned OracleBaseFaileSystem 
as Oracle10R2FileSystem, and make OracleFileSystem inheriit from it. I don't 
like this either.
WDYYT?
Regards,


> Jackrabbit depends on Oracle driver for BLOB support in Oracle versions 
> previous than 10.2
> ------------------------------------------------------------------------------------------
>
>                 Key: JCR-1525
>                 URL: https://issues.apache.org/jira/browse/JCR-1525
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Esteban Franqueiro
>
> In Oracle versions previous to 10.2, Jackrabbit explicitly uses a class from 
> the Oracle driver to provide BLOB support (see OracleFileSystem.init()). This 
> special handling is no longer necesary for Oracle 10.2+, so we should provide 
> a new implementation. As discussed on the list, we can create a new class for 
> Oracle 10.2+, make it inherit from DbFileSystem, and override the 
> createSchema(), and table space related methods, which are the ones that need 
> special handling. Furthermore, we could refactor the current OracleFileSystem 
> and break it into two clases, one of them to keep the current behavior and a 
> new one to keep the common code (which we could rename to 
> OracleBaseFileSystem or similar, to maintain compatiblity with code that uses 
> OracleFileSystem for versions previous to 10.2). Then we make the 
> Oracle10FileSystem inherit from the latter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to