[ 
https://issues.apache.org/jira/browse/JCR-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621530#action_12621530
 ] 

fabrizio giustina commented on JCR-1694:
----------------------------------------

I wasn't aware of the org.apache.jackrabbit.core.cluster.node_id "magic" 
property, but since you can use system variables everywhere in the config file 
with a standard mechanism (except here, at the moment) IMHO it would be better 
to handle it consistently.
Since it's more generic I think the way system properties are replaced using 
${variables} is easier and more self-explanatory. This could also fully replace 
the "org.apache.jackrabbit.core.cluster.node_id" property, by just setting the 
default to ${org.apache.jackrabbit.core.cluster.node_id}. My vote to add the 
generic replacement of variables in the cluster config too.

> System properties does not get replaced in a Cluster configuration
> ------------------------------------------------------------------
>
>                 Key: JCR-1694
>                 URL: https://issues.apache.org/jira/browse/JCR-1694
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: config
>    Affects Versions: core 1.4.5
>            Reporter: fabrizio giustina
>         Attachments: JCR-1694-fix.diff, JCR-1694-testcase.diff
>
>
> Since JCR-1304 has been added to jackrabbit 1.4 I guess this should be 
> reported as a bug...
> Still not debugged deeply, but if I try to configure a Cluster using:
> <Cluster id="${server}" syncDelay="10">
> after setting a "server" system property I expect to have the cluster 
> initialized properly using the value of such property... I just realized that 
> my cluster node gets initialized with the final value of "${server}" instead 
> :(
> Cluster config is a very good place where to use system properties, since all 
> the configuration is usually identical between cluster nodes while the "id" 
> property must be different...
> Is there anything I missed/did wrong in my configuration?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to