[ 
https://issues.apache.org/jira/browse/JCR-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig updated JCR-1638:
-------------------------------

    Attachment: JCR-1638-2.patch

Attempted clean up of previous patch. This results in the following test 
failures:

testNode(org.apache.jackrabbit.test.api.SetValueVersionExceptionTest)
testGetVersionLabelsForInvalidVersion(org.apache.jackrabbit.test.api.version.VersionLabelTest)
testRestoreWithInvalidVersion(org.apache.jackrabbit.test.api.version.RestoreTest)
testRestoreOrder(org.apache.jackrabbit.test.api.version.RestoreTest)
testWorkspaceRestoreWithParent(org.apache.jackrabbit.test.api.version.WorkspaceRestoreTest)
testNotLockedAfterLogout(org.apache.jackrabbit.jcr2spi.lock.SessionScopedLockTest)
testLogoutHasNoEffect(org.apache.jackrabbit.jcr2spi.lock.OpenScopedLockTest)

This seems to indicate that some of the client of NodeEntry.getNodeEntry(Name, 
int,  boolean) rely on the (IMHO wrong) interpretation of the last argument.


> Redundant calls to RepositoryService.getChildInfos
> --------------------------------------------------
>
>                 Key: JCR-1638
>                 URL: https://issues.apache.org/jira/browse/JCR-1638
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-jcr2spi
>            Reporter: Michael Dürig
>         Attachments: JCR-1638-2.patch, JCR-1638.patch
>
>
> In some cases jcr2spi issues calls to RepositoryService.getChildInfos for 
> items which haven been returned by the last call to 
> RepositoryService.getItemInfos. 
> This happens because WorkspaceItemStateFactory.createDeepPropertyState is 
> asked to create the node states for all items returned by 
> RepositoryService.getChildInfos in the order they are returned by the 
> Iterator. When trying to create an item state for an item which is deeper 
> down the hierarchy than another item which comes later in the iterator, a 
> call to RepositoryService.getChildInfos is issued for the latter. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to