[
https://issues.apache.org/jira/browse/JCR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623466#action_12623466
]
Thomas Mueller commented on JCR-1718:
-------------------------------------
> <!ELEMENT Repository
> (Cluster|FileSystem|DataStore|Security|Workspaces|Workspace|Versioning|SearchIndex)*>
>
This would allow same name siblings, for example multiple Cluster elements in
the same repository.xml.
> I'd rather not break things for people who may be validating the
> repository.xml.
While I don't have any numbers, I don't think many people do validate the
repository.xml. Remember also we already broke all existing (old)
repository.xml configurations by adding "SecurityManager" in "Security". I
agree, the order of elements does not seem to be important, but I would rather
have a strict order than not detecting typos (as we do now).
> We can still spit out warnings/errors in Jackrabbits configuration parser if
> required elements are missing - or is that already the case?
Yes, that already works: I have removed the top FileSystem element, and got the
exception
javax.jcr.RepositoryException: Invalid repository configuration:
repository.xml: Configuration element FileSystem not found in Repository.:
Configuration element FileSystem not found in Repository.
> At least a change like this requires an update to the DTD version.
I don't think we did that in the past. Jackrabbit 1.4 uses repository-1.4.dtd.
repository-1.5.dtd is only used in the Jackrabbt trunk. I don't think changes
in the unreleased Jackrabbit 1.5 requires an update in the DTD version. Using
repository-1.6.dtd for Jackrabbit 1.5 would be confusing.
So, I still like to change it to:
<!ELEMENT Repository
(Cluster?,FileSystem,DataStore?,Security,Workspaces,Workspace,Versioning,SearchIndex?)>
What do you think?
> repository-1.5.dtd: change order of main elements
> -------------------------------------------------
>
> Key: JCR-1718
> URL: https://issues.apache.org/jira/browse/JCR-1718
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Minor
>
> Currently the order of elements in repository.xml is:
> <!ELEMENT Repository
> (FileSystem,Security,Workspaces,Workspace,Versioning,SearchIndex?,Cluster?,DataStore?)>
> I would like to change it to
> <!ELEMENT Repository
> (Cluster?,FileSystem,DataStore?,Security,Workspaces,Workspace,Versioning,SearchIndex?)>
> because I think that makes more sense.
> Currently XML validation is disabled, and therefore the order of elements in
> the DTD does not need to match the repository.xml file. However as soon as
> XML validation is enabled, repository.xml files that use the wrong order will
> no longer work (the repository can not be started).
> There is a request to enable XML validation at
> http://issues.apache.org/jira/browse/JCR-1462
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
