[
https://issues.apache.org/jira/browse/JCR-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626376#action_12626376
]
Thomas Mueller commented on JCR-1456:
-------------------------------------
Thanks for the patch!
> It's really not complicated at all. There is one class
> (ThreadLocalConnectionProviderAdapter...
This class does look complicated to me. To avoid ThreadLocal, what about:
BundleDbPersistenceManager {
Connection currentConnection
synchronized store(..) {
try {
currentConnection = ...
super.store(..)
} finally {
currentConnection = null
}
}
> the patch hasn't been heavily tested in "real world"
I have already said, manual tests and real world tests are a maintenance
problem. If there is no automated test, each change is big risk. Maintaining
and improving the code is very hard in this case.
> Database connection pooling
> ---------------------------
>
> Key: JCR-1456
> URL: https://issues.apache.org/jira/browse/JCR-1456
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Jukka Zitting
> Fix For: 1.5
>
> Attachments: patch-1456-1.txt, patch-1456-2.txt, patch-1456-3.txt
>
>
> Jackrabbit should use database connection pools instead of a single
> connection per persistence manager, cluster journal, or database data store.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
