[
https://issues.apache.org/jira/browse/JCR-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634415#action_12634415
]
angela commented on JCR-1732:
-----------------------------
thanks martin for working on that.
i would like to suggest 2 comments or improvements
- DavConstants.java is intended to contain constants for the dav 1,2 compliant
set.
version related constants are (or should be) placed in the
version/DeltaVConstants.
- from my understanding of the spec the format of the DAV:checkout request body
is less restrictive than your implementation:
<!ELEMENT checkout ANY>
with some special cases defined in the various section of rfc 3253, namely
- 4.3
http://www.webdav.org/specs/rfc3253.html#checkout.method.applied.to.a.version-controlled.resource
- 8.8 http://www.webdav.org/specs/rfc3253.html#rfc.section.8.8
- 9.3 http://www.webdav.org/specs/rfc3253.html#rfc.section.9.3
- 13.10 http://www.webdav.org/specs/rfc3253.html#rfc.section.13.10
consequently i would prefer a constructor that provided more flexibility, e.g.
passing an xml element.
if you think that some of the cases described in the various sections above
would use more often (e.g. the activity-set) it's fine to have a separate
constructor that. but i would prefer taking care of one specific case and
keep it closer to the spec (e.g. as far as i know the activity set may contain
more than one href element and may alternatively contain an empty 'new'
element.
angela
> WEBDAV CHECKOUT may contain request body
> ----------------------------------------
>
> Key: JCR-1732
> URL: https://issues.apache.org/jira/browse/JCR-1732
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jackrabbit-webdav
> Reporter: Martin Jung
> Priority: Minor
> Attachments: CheckoutMethod.java, DavConstants.java
>
>
> I picked up a todo from the webdav client package.
> "CHECKOUT may contain request body (working-resource, activity,
> checkout-in-place)" With the additional constructor the checkout can deal
> with working-resource and activity.
> Hopefully it is ok and it finds a way in the Lib
> Cheers,
> Martin
> --
> Martin Jung
> master student
> DLR (German Aerospace Center),
> Simulation and Software Technology
> Linder Hoehe, 51147 Cologne, Germany
> voice: +49 2203 601 2956 fax: +49 2203 601 3070
> eMail: m.jung at dlr.de http://www.dlr.de/sc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
