[ 
https://issues.apache.org/jira/browse/JCR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644323#action_12644323
 ] 

Marcel Reutegger commented on JCR-1845:
---------------------------------------

I'm for removing the method, unless there's a good reason to keep it. The 
SessionImporter class can use the getValue(InputStream) method instead.


> clarify QValueFactory.create(File)
> ----------------------------------
>
>                 Key: JCR-1845
>                 URL: https://issues.apache.org/jira/browse/JCR-1845
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi
>            Reporter: Julian Reschke
>            Priority: Minor
>
> We should either remove this method, or improve the documentation; right now 
> it's only used in o.a.j.jcr2spi.xml.SessionImporter.
> If we keep it, we should clarify whose reponsibility it is to remove the File 
> when done (right now, it seems to be the QValue's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to