[ 
https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661753#action_12661753
 ] 

Bart van der Schans commented on JCR-1918:
------------------------------------------

The code in 1.5 and trunk has clearly improved and looks much better. The idea 
of this patch instead of backporting the other patches is that it fixes the 
specific problem without doing any refactoring, minimizing the risk of 
introducing new behavior or bugs. We will be upgrading to 1.5 within the next 
month, but I could still be useful to people who are stuck to 1.4 when a new 
maintenance release is done of the core.

For some background: I ran into this bug when importing some 15GB of data for a 
customer. Without the patch I ran into OOMs using 1GB of memory within 40 
minutes. With the patch the import script was running fine for almost 2 days 
straight getting all the data in. The setup  was running on linux 64bit with 
java 6 64bit in Tomcat 6 with mysql configured as a datasource.

> DbDataStore keeps ResultSets open
> ---------------------------------
>
>                 Key: JCR-1918
>                 URL: https://issues.apache.org/jira/browse/JCR-1918
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.6
>            Reporter: Bart van der Schans
>         Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory 
> leaks and/or large memory usage. It seems that  this already has been fixed 
> in trunk and 1.5.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to