[ 
https://issues.apache.org/jira/browse/JCR-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662193#action_12662193
 ] 

Jukka Zitting commented on JCR-1269:
------------------------------------

Hmm, should I have asked before committing this?

There are old -1s from Stefan and Felix (on the mailing list), but I figured 
that they applied to the era when we still had some code that actually did 
catch BaseExceptions. As Angela mentioned, the last such cases were gone in 
April last year, and currently the BaseException class is just dead code.

I'll revert the change if someone still feels against this (why?), otherwise 
I'll assume lazy consensus and leave my commit as is.

> Stop using BaseException
> ------------------------
>
>                 Key: JCR-1269
>                 URL: https://issues.apache.org/jira/browse/JCR-1269
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: BaseException.patch
>
>
> The o.a.j.BaseException class is deprecated (since JCR-1169) and not caught 
> anywhere, so there's no need to keep using it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to