[ 
https://issues.apache.org/jira/browse/JCR-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688675#action_12688675
 ] 

Michael Dürig commented on JCR-1695:
------------------------------------

Revision 757775  introduces o.a.j.spi.commons.logging.*

In the most simple case

  RepositoryService loggingService = SpiLoggerFactory.create(service);

creates a log wrapper for service which logs all calls to its methods if 
logging at the debug level is enabled. If logging is not enabled, no log 
wrapper is created at all and service itself is returned. There is thus 
virtually no overhead from disabled loggers. Loggers are enabled and disabled 
via the configuration mechanism of the logging framework which is in place.


> Improve and promote spi-logger
> ------------------------------
>
>                 Key: JCR-1695
>                 URL: https://issues.apache.org/jira/browse/JCR-1695
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons, sandbox
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> The spi-logger is very useful for debugging an SPI implementation. However it 
> only supports the RepositoryService interface. Other SPI interfaces are not 
> supported. Also writing log information as string seems a bit restrictive to 
> me. Finally it is not included in the jackrabbit-spi package which introduces 
> an additional dependency for debugging. 
> I therefore suggest:
> - Add support for the other major SPI interfaces 
> - Replace the current way of logging a String to a Writer instance by a more 
> versatile mechanism (i.e. clients have to provide an interface which consumes 
> more structured log data). 
> - Provide some default implementation for the above mechanism (i.e. writing 
> to a file, writing to a slf4j based logger, writing to the console...)
> - Promote this project to jackrabbit-spi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to