thanks for reviewing! Sorry about the absense of a test, I'll have to look into how to do that. I guess it should be possible by creating a mock repository service to fabricate the updates(?)
Frank On Tue, Apr 21, 2009 at 6:00 PM, Jukka Zitting <jukka.zitt...@gmail.com>wrote: > Hi, > > On Tue, Apr 21, 2009 at 12:31 PM, Frank van Lankvelt > <f.vanlankv...@onehippo.com> wrote: > > could issue JCR-2016 (jcr2spi) be considered for inclusion? There is a > > patch attached that fixes some faults in the update processing. I.e. a > > correct update leads to an incorrect state. > > Sure, sorry that nobody has commented on the patch yet. (Perhaps we > should start using the "patch available" workflow in Jira...) > > The patch looks reasonably OK, though I'd need to review it in a bit > more detail before applying it. Any chance of getting a test case for > it? :-) > > BR, > > Jukka Zitting >