[
https://issues.apache.org/jira/browse/JCR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting updated JCR-509:
------------------------------
Status: Patch Available (was: Open)
> TCK: NodeTest#testNodeIdentity fails if versioning and locking not supported
> ----------------------------------------------------------------------------
>
> Key: JCR-509
> URL: https://issues.apache.org/jira/browse/JCR-509
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: David Pitfield
>
> The test calls isCheckedOut and isLocked without testing whether versioning
> and locking are supported.
> Proposal: call isCheckedOut only if versioning is supported; call isLocked
> only if locking is supported.
> --- NodeTest.java (revision 422074)
> +++ NodeTest.java (working copy)
> @@ -757,8 +769,12 @@
> // check if they have the same child
> assertEquals("Two references of same node have different children",
> testNode1.getNode(nodeName1), testNode2.getNode(nodeName1));
> // check state methods
> - assertEquals("Two references of same node have different State for
> Node.isCheckedOut()", testNode1.isCheckedOut(), testNode2.isCheckedOut());
> - assertEquals("Two references of same node have different State for
> Node.isLocked()", testNode1.isLocked(), testNode2.isLocked());
> + if (isSupported(Repository.OPTION_VERSIONING_SUPPORTED)) {
> + assertEquals("Two references of same node have different State for
> Node.isCheckedOut()", testNode1.isCheckedOut(), testNode2.isCheckedOut());
> + }
> + if (isSupported(Repository.OPTION_LOCKING_SUPPORTED)) {
> + assertEquals("Two references of same node have different State for
> Node.isLocked()", testNode1.isLocked(), testNode2.isLocked());
> + }
> assertEquals("Two references of same node have different State for
> Node.isModified()", testNode1.isModified(), testNode2.isModified());
> assertEquals("Two references of same node have different State for
> Node.isNew()", testNode1.isNew(), testNode2.isNew());
> assertEquals("Two references of same node have different State for
> Node.isNode()", testNode1.isNode(), testNode2.isNode());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
