[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732525#action_12732525
]
Jukka Zitting commented on JCR-1972:
------------------------------------
Thanks for the update! Still more comments:
* It would be better if the UUID argument was a String instead of an instance
of the UUID class. Also, it might be useful to rename the relevant methods to
addNodeWithUUUID to avoid signature clashes with the already overloaded addNode
method.
* It would be good to have javadocs for all the new methods.
* Please use only spaces to indent the code.
* About the duplicate methods: It's OK to have extra method signatures for
different purposes, but now you're duplicating also the entire method bodies.
For example the new NodeImpl.checkin(Calendar) method is some 40 lines of code
that's essentially identical to the code in NodeImpl.checkin(). If we later on
encounter a bug and fix it in the checkin() method, how do we make sure that
the fix also gets applied to checkin(Calendar)?
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch,
> JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some
> changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to
> preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node
> definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and
> there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
