[ 
https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735022#action_12735022
 ] 

angela commented on JCR-2192:
-----------------------------

rev. 797410:

- changed the name handling in the *Template implementations
- added ConstraintViolationException in case of invalid jcr names
  BUT: except for the residual item-definition name -> added specially handling

- rechecked the default-values of empty *Templates as defined by the javadoc 
and adjusted
  the code accordingly
- added test-cases for the empty *Template default values
- added some more tests for the various setters
- added test for setting illegal JCR names
- added test for setting residual item def name

- in addition (not mandated by the specification) i added trivial validation 
for 
  > RequiredPropertyType
  > OPV flag
  > since those setters don't allow any exceptions illegalargexp is thrown.
  > and added implementation specific test cases.

TODOs:

- The specification doesn't define the default values for a couple of new 
methods (see 283 issue 798)
- Handling of ValueConstraints needs more clarification (see 794)
- The default values defined for DeclaredSuperTypeNames looked not very 
consistent to me (see 797)

-> added TODOs both in the TCK tests and in the *TemplateImpl code

> handling of expanded-form jcr names by node type *Template classes 
> -------------------------------------------------------------------
>
>                 Key: JCR-2192
>                 URL: https://issues.apache.org/jira/browse/JCR-2192
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi-commons, JCR 2.0
>            Reporter: Julian Reschke
>            Assignee: angela
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
>   "{http://example.org/}foo";
> then getName() needs to return
>   "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/";.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to