[
https://issues.apache.org/jira/browse/JCR-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753592#action_12753592
]
Michael Dürig commented on JCR-2301:
------------------------------------
I still prefer to keep the parser independent. Although it adds some complexity
(in particular AbstractItemTypeDefinitionsBuilder and its implementations), it
adds a great deal of flexibility. Also that way, changes to client code is
minimal.
With the proposed patch it is quite easy to parametrize the parser such that it
generates a JCR 2.0 API *Template bases representation of the CND. Just
implement an AbstractItemTypeDefinitionsBuilder<NodeTypeTemplate, N...> and
pass it to CompactNodeTypeDefReader's constructor.
Also note that the parser is currently used to create two different
representations of the CND (one in core, another in spi). AFAIU you want to use
it to create yet another representation (JCR API node types/templates).
Therefore I think it doesn't make sense to move the parser close to one
specific representation. BTW it was moved from core to spi already (JCR-1516)
because we then thought the spi representation would be the more general one.
> CND support in jackrabbit-jcr-commons
> -------------------------------------
>
> Key: JCR-2301
> URL: https://issues.apache.org/jira/browse/JCR-2301
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-jcr-commons, nodetype
> Reporter: Jukka Zitting
> Attachments: JCR-2301-poc.patch
>
>
> It would be nice if the CND parsing functionality in spi-commons could be
> made available in jcr-commons for use by JCR clients that shouldn't have to
> know anything about the SPI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
