[ 
https://issues.apache.org/jira/browse/JCR-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829049#action_12829049
 ] 

angela commented on JCR-2482:
-----------------------------

> I'm not saying that the commit should be rolled back, just wondering what 
> others think.

i'm very happy with the changes made by michael and i consider this kind of 
minor code improvements
and cleanups as very valuable. the @Override lines never bothered me and they 
actually are a reasonable
replacement for my @see xzw-method comments that i tried to add consistently in 
order to force the ide
to inform me about changes made to super-classes such as michael pointed out 
above [yes, i use to have 
javadoc problems reported as error] 

> Reduce number of compiler warning by adding @Override and generics where 
> appropriate 
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-2482
>                 URL: https://issues.apache.org/jira/browse/JCR-2482
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi
>    Affects Versions: 2.1.0
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 2.1.0
>
>
> Add @Override and generics where possible to reduce the number of warnings 
> issued by the compiler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to