[ 
https://issues.apache.org/jira/browse/JCR-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Dettman updated JCR-2676:
-------------------------------

    Attachment: JCR-2676.patch

Patch of FileDataStore to check for lastModified return code of "0", indicating 
error.

- in addRecord and getRecordIfStored, it's an error if lastModified fails, 
since we can't tell whether to call setLastModified or not.

- in deleteOlderRecursive, we just log a warning, and make sure not to delete 
the file!

Also added a warning if the call to File.delete fails in deleteOlderRecursive


> FileDataStore should check for lastModified error result
> --------------------------------------------------------
>
>                 Key: JCR-2676
>                 URL: https://issues.apache.org/jira/browse/JCR-2676
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.1.0
>            Reporter: Peter Dettman
>         Attachments: JCR-2676.patch
>
>
> According to javadoc for File.lastModified(), the return value may indicate 
> error: "...or 0L if the file does not exist or if an I/O error occurs".
> Accordingly, FileDataStore should be checking for this return value, rather 
> than treating it as an actual modification time of "0".
> Patch to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to