[ 
https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918494#action_12918494
 ] 

Jukka Zitting commented on JCR-2763:
------------------------------------

> what about SessionImpl.dump()?

I dropped it because SessionImpl already had a toString() method and it seemed 
wrong to include too many internal details in the return value of a method 
that's directly accessible by JCR clients. We could instead print out the 
component details in SessionContext.toString(). I'll take a look at that.

> i fail to see any benefit in removing this interface. what was your 
> motivation?

The same functionality can be implemented in a more interoperable way using 
toString() methods. As an added bonus we even get rid of one extra internal 
abstraction.

> Drop the Dumpable interface
> ---------------------------
>
>                 Key: JCR-2763
>                 URL: https://issues.apache.org/jira/browse/JCR-2763
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-spi2jcr
>            Reporter: Jukka Zitting
>            Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for 
> diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to 
> drop the interface and refactor the dump() methods in various Jackrabbit 
> classes to more detailed toString() methods that would be more useful to 
> debuggers and other general-purpose diagnostic tools.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to