[
https://issues.apache.org/jira/browse/JCR-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930980#action_12930980
]
Thomas Mueller commented on JCR-2809:
-------------------------------------
There is one more bug when using XA: the timeout time (when will it expire
since 1970) is used as the timeout hint (number of seconds until it expires).
But anyway the timeout was ignored when using XA.
> Lock expires almost immediately
> -------------------------------
>
> Key: JCR-2809
> URL: https://issues.apache.org/jira/browse/JCR-2809
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: locks
> Affects Versions: 2.1.2
> Reporter: Dominique Pfister
> Assignee: Thomas Mueller
>
> When a timeoutHint other than Long.MAX_VALUE is given to the
> javax.jcr.lock.LockManager API:
> lock(String absPath, boolean isDeep, boolean isSessionScoped, long
> timeoutHint, String ownerInfo)
> a timeoutTime in seconds will be computed as follows
> (o.a.j.core.lock.LockInfo#updateTimeoutTime):
> long now = (System.currentTimeMillis() + 999) / 1000; // round up
> this.timeoutTime = now + timeoutHint;
> the TimeoutHandler in o.a.j.core.lock.LockManagerImpl running every second
> will then check whether the timeout has expired
> (o.a.j.core.lock.LockInfo#isExpired):
> public boolean isExpired() {
> return timeoutTime != Long.MAX_VALUE
> && timeoutTime * 1000 > System.currentTimeMillis();
> }
> Obviously, the latter condition is true from the very beginning. Replacing
> '>' with '<' or '<=' should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
