[ 
https://issues.apache.org/jira/browse/JCR-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Parvulescu updated JCR-2916:
---------------------------------

    Attachment: JCR-2916-fields-v2.patch

oops, good catch :)

That also goes for ChainedTermEnumTest. 
I redid the patch.

I also changed the IDFieldTest to show the difference between the 2 
constructors.
Interesting enough, just taking out id.toString() shaved off more than 90% of 
the test time so it may not have been the most conclusive test.
(for me the old test went from 800ms to 30ms)

Anyway, now it compares the 2 ways, so it should be a tiny bit more relevant.




> Avoid String.intern() when indexing
> -----------------------------------
>
>                 Key: JCR-2916
>                 URL: https://issues.apache.org/jira/browse/JCR-2916
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-2916-fields-v2.patch, JCR-2916-fields.patch
>
>
> Lucene 3.0 now allows to create Fields with a String name that is already 
> interned. We should use the new constructor in NodeIndexer to avoid 
> unnecessary String.intern() calls. The field names Jackrabbit uses are 
> available in FieldNames and already interned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to