Hi,

I think we should provide means for having a commit message. That message should also go to the journal such that it can be retrieved by calling getRevisions(). See attached patch for details.

The rational for this change is that implementing the User Data functionality [1] is not feasible on top of the current MicroKernel API.

Michael

[1] http://www.day.com/specs/jcr/2.0/12_Observation.html#12.3.5%20User%20Data
Index: src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java
===================================================================
--- src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java (revision 
1136039)
+++ src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java (revision )
@@ -128,7 +128,7 @@
      * <p/>
      * Format:
      * <pre>
-     * [ { "id" : "<revisionId>", "ts" : <revisionTimestamp>, "changes" : 
"<JSON diff>" }, ... ]
+     * [ { "id" : "<revisionId>", "ts" : <revisionTimestamp>, "msg" 
<commitMessage>, "changes" : "<JSON diff>" }, ... ]
      * </pre>
      *
      * @param fromRevisionId first revision to be returned in journal
@@ -235,10 +235,11 @@
      * @param path path denoting target node
      * @param jsonDiff changes to be applied in JSON diff format.
      * @param revisionId revision the changes are based on
+     * @param message commit message
      * @return id of newly created revision
      * @throws MicroKernelException if an error occurs
      */
-    String /* revisionId */ commit(String path, String jsonDiff, String 
revisionId)
+    String /* revisionId */ commit(String path, String jsonDiff, String 
revisionId, String message)
             throws MicroKernelException;
 
 

Reply via email to