[ 
https://issues.apache.org/jira/browse/JCR-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108455#comment-13108455
 ] 

angela commented on JCR-3070:
-----------------------------

there are 2 related methods on SessionImpl : isAdmin and isSystem which were 
extracted to prevent 
hardcoded checks for the admin userID or checks for the session being an 
instance of SystemSession. 
both were quite frequent in jackrabbit (see JCR-2886).

having SystemSession#isAdmin to return true was IMO a conceptional mistake. 
either the operations
you think of lack to test for the session being SystemSession... or maybe there 
was a reason why the original
author expected no systemsession to execute it?

> SystemSession.isAdmin() should return true
> ------------------------------------------
>
>                 Key: JCR-3070
>                 URL: https://issues.apache.org/jira/browse/JCR-3070
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.2.7
>            Reporter: Tobias Bocanegra
>             Fix For: 2.3.0
>
>
> the current SystemSession returns false for "isAdmin()". operations that only 
> check for
> session.isAdmin() will fail for system sessions.
> suggest to change this to return "true".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to