[ 
https://issues.apache.org/jira/browse/JCR-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jukka Zitting reopened JCR-3063:
--------------------------------


Hmm, unfortunately this introduces a deadlock even though it's not exactly the 
same as in JCR-2171. See below for the case where two concurrent threads are 
trying to save() the same items (stack traces from ConcurrentImportTest):

"Executor 12" prio=10 tid=0x00007f3aac5df000 nid=0x7088 waiting for monitor 
entry [0x00007f3a84247000]
   java.lang.Thread.State: BLOCKED (on object monitor)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.getItemState(LocalItemStateManager.java:169)
        - waiting to lock <0x00000007dbeb3118> (a 
org.apache.jackrabbit.core.state.XAItemStateManager)
        at 
org.apache.jackrabbit.core.state.XAItemStateManager.getItemState(XAItemStateManager.java:260)
        at 
org.apache.jackrabbit.core.state.SessionItemStateManager.stateCreated(SessionItemStateManager.java:796)
        at 
org.apache.jackrabbit.core.state.StateChangeDispatcher.notifyStateCreated(StateChangeDispatcher.java:94)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.stateCreated(LocalItemStateManager.java:439)
        at 
org.apache.jackrabbit.core.state.StateChangeDispatcher.notifyStateCreated(StateChangeDispatcher.java:94)
        at 
org.apache.jackrabbit.core.state.SharedItemStateManager.stateCreated(SharedItemStateManager.java:405)
        at 
org.apache.jackrabbit.core.state.ItemState.notifyStateCreated(ItemState.java:233)
        at 
org.apache.jackrabbit.core.state.ChangeLog.persisted(ChangeLog.java:309)
        at 
org.apache.jackrabbit.core.state.SharedItemStateManager$Update.end(SharedItemStateManager.java:785)
        at 
org.apache.jackrabbit.core.state.SharedItemStateManager.update(SharedItemStateManager.java:1500)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.update(LocalItemStateManager.java:352)
        at 
org.apache.jackrabbit.core.state.XAItemStateManager.update(XAItemStateManager.java:354)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.update(LocalItemStateManager.java:327)
        at 
org.apache.jackrabbit.core.state.SessionItemStateManager.update(SessionItemStateManager.java:288)
        at 
org.apache.jackrabbit.core.ItemSaveOperation.perform(ItemSaveOperation.java:258)
        at 
org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:200)
        at org.apache.jackrabbit.core.ItemImpl.perform(ItemImpl.java:91)
        at org.apache.jackrabbit.core.ItemImpl.save(ItemImpl.java:329)
        at 
org.apache.jackrabbit.core.session.SessionSaveOperation.perform(SessionSaveOperation.java:64)
        at 
org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:200)
        at org.apache.jackrabbit.core.SessionImpl.perform(SessionImpl.java:360)
        at org.apache.jackrabbit.core.SessionImpl.save(SessionImpl.java:809)

"Executor 0" prio=10 tid=0x00007f3aac63c800 nid=0x707c in Object.wait() 
[0x00007f3a84e53000]
   java.lang.Thread.State: WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        - waiting on <0x0000000784e9b808> (a 
org.apache.jackrabbit.core.state.DefaultISMLocking)
        at java.lang.Object.wait(Object.java:485)
        at 
org.apache.jackrabbit.core.state.DefaultISMLocking.acquireReadLock(DefaultISMLocking.java:118)
        - locked <0x0000000784e9b808> (a 
org.apache.jackrabbit.core.state.DefaultISMLocking)
        at 
org.apache.jackrabbit.core.state.SharedItemStateManager.acquireReadLock(SharedItemStateManager.java:1847)
        at 
org.apache.jackrabbit.core.state.SharedItemStateManager.getItemState(SharedItemStateManager.java:265)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.getPropertyState(LocalItemStateManager.java:133)
        at 
org.apache.jackrabbit.core.state.LocalItemStateManager.getItemState(LocalItemStateManager.java:175)
        - locked <0x00000007dbeb3118> (a 
org.apache.jackrabbit.core.state.XAItemStateManager)
        at 
org.apache.jackrabbit.core.state.XAItemStateManager.getItemState(XAItemStateManager.java:260)
        at 
org.apache.jackrabbit.core.state.SessionItemStateManager.getItemState(SessionItemStateManager.java:162)
        at 
org.apache.jackrabbit.core.ItemManager.getItemData(ItemManager.java:370)
        at 
org.apache.jackrabbit.core.ItemSaveOperation.validateTransientItems(ItemSaveOperation.java:538)
        at 
org.apache.jackrabbit.core.ItemSaveOperation.perform(ItemSaveOperation.java:216)
        at 
org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:200)
        at org.apache.jackrabbit.core.ItemImpl.perform(ItemImpl.java:91)
        at org.apache.jackrabbit.core.ItemImpl.save(ItemImpl.java:329)
        at 
org.apache.jackrabbit.core.session.SessionSaveOperation.perform(SessionSaveOperation.java:64)
        at 
org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:200)
        at org.apache.jackrabbit.core.SessionImpl.perform(SessionImpl.java:360)
        at org.apache.jackrabbit.core.SessionImpl.save(SessionImpl.java:809)
                
> NullPointerException in ItemManager
> -----------------------------------
>
>                 Key: JCR-3063
>                 URL: https://issues.apache.org/jira/browse/JCR-3063
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.2.5, 2.2.8
>            Reporter: Unico Hommes
>             Fix For: 2.2.9
>
>         Attachments: NPEandCMETest.java
>
>
> We have a lot of these occurring:
> java.lang.NullPointerException
>       at 
> org.apache.jackrabbit.core.ItemManager.getDefinition(ItemManager.java:206)
>       at org.apache.jackrabbit.core.ItemData.getDefinition(ItemData.java:99)
>       at 
> org.apache.jackrabbit.core.AbstractNodeData.getNodeDefinition(AbstractNodeData.java:73)
>       at org.apache.jackrabbit.core.NodeImpl.getDefinition(NodeImpl.java:2430)
>       at 
> org.apache.jackrabbit.core.ItemValidator.isProtected(ItemValidator.java:373)
>       at 
> org.apache.jackrabbit.core.ItemValidator.checkCondition(ItemValidator.java:273)
>       at 
> org.apache.jackrabbit.core.ItemValidator.checkRemove(ItemValidator.java:254)
>       at 
> org.apache.jackrabbit.core.ItemRemoveOperation.perform(ItemRemoveOperation.java:63)
>       at 
> org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:200)
>       at org.apache.jackrabbit.core.ItemImpl.perform(ItemImpl.java:91)
>       at org.apache.jackrabbit.core.ItemImpl.remove(ItemImpl.java:322)
>       at 
> org.apache.jackrabbit.core.NPEandCMETest$TestTask.run(NPEandCMETest.java:87)
>       at java.lang.Thread.run(Thread.java:679)
> I'll attach a junit test to reproduce this exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to