[ 
https://issues.apache.org/jira/browse/JCR-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121792#comment-13121792
 ] 

Jukka Zitting commented on JCR-3005:
------------------------------------

Looks good, thanks! I committed the patch as-is in revision 1179531 and changed 
it slightly in revision 1179532 to allow exceptions from the getMultiple method 
instead of just logging them (BTW, we use SLF4J for logging).

Some comments on the implementation:

* Wouldn't it make more sense for this to be a GET request rather than a POST? 
Something like: curl 
'http://localhost:8080/server/workspace/jcr:root/node2.0.json?:get=/node1&:get=/node2'

* Instead of implementing parts of the JSON serialization in the getSimple() 
method, it would be cleaner to add a method like JsonWriter.write(Node[] nodes, 
int depth)

* The return statement inside the conditional in doPost() increases the 
complexity of the already tricky flow of that method. Can we refactor the code 
slightly to make the flow more obvious?

                
> Make it possible to get multiple nodes in one call via davex
> ------------------------------------------------------------
>
>                 Key: JCR-3005
>                 URL: https://issues.apache.org/jira/browse/JCR-3005
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-jcr-server
>            Reporter: Christian Stocker
>         Attachments: getSessions.patch
>
>
> I'm working on this currently

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to