On 2011-10-08 05:48, Dave Brosius wrote:
This comparator seems odd to me, as it never returns (d) but perhaps i'm confused, is it ok?org.apache.jackrabbit.core.query.lucene.sort.ValueComparableWrapper public int compareTo(ValueComparableWrapper o) { final int d = compare(v, o.getValue()); if (d != 0) { if (reversed) { return -d; } return -d; } return 0; }
It certainly looks broken. (If it's intended it would need a comment explaining why it is so)
Do we need a test before fixing? Best regards, Julian
