[ 
https://issues.apache.org/jira/browse/JCR-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150450#comment-13150450
 ] 

Alex Parvulescu commented on JCR-3146:
--------------------------------------

thanks for taking the time to review the patch

> To me it seems like this should never happen, right? 
yes, that is just premature optimization. I'll remove it.

> Should we rather keep the JackrabbitThreadPool package private and only 
> expose the marker as public interface?
you mean like moving the interface to the util package?

> How about renaming the LOW_PRIORITY_MARKER to LowPriorityTask and extend it 
> from Runnable?
that is a good idea

> Aren't the additional index flush calls in IndexingQueueTest now obsolete?
true. I had some issues with timing which are now hopefully fixed, so yes we 
can remove the extra flush


                
> Text extraction may congest thread pool in the repository
> ---------------------------------------------------------
>
>                 Key: JCR-3146
>                 URL: https://issues.apache.org/jira/browse/JCR-3146
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-3146.patch
>
>
> Text extraction congests the thread pool in the repository when e.g. many 
> PDFs are loaded into the workspace. Tasks submitted by the index merger are 
> delayed because of that and will result in many index segment folders.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to