[ 
https://issues.apache.org/jira/browse/JCR-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168350#comment-13168350
 ] 

Marcel Reutegger commented on JCR-3162:
---------------------------------------

Thanks for the patch.

I see that you moved the initial index creation from the SearchIndex to the 
MultiIndex. This is how it was before JCR-1064, where we had to move it out of 
the MultiIndex. I'm not sure if it is now safe to move the initial index 
creation trigger back to the SearchIndex...

The are some imports which look odd. The class ClusterNode imports the 
MultiIndex, though this is probably just minor because it is not really 
required to compile the class, but only to resolve the javadoc reference. More 
troublesome is the import of DbClusterTestJCR3162 in SearchManager. That 
doesn't work because DbClusterTestJCR3162 is a test class.

I'm also wordering if it is possible to fix this issue without introducing too 
much changes to the journal/cluster code. Wouldn't it be sufficient to use the 
existing journal and cluster node interface to get changes from a given 
revision?
                
> Index update overhead on cluster slave due to JCR-905
> -----------------------------------------------------
>
>                 Key: JCR-3162
>                 URL: https://issues.apache.org/jira/browse/JCR-3162
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: clustering
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-3162-v2.patch, JCR-3162-v3.patch, JCR-3162.patch
>
>
> JCR-905 is a quick and dirty fix and causes overhead on a cluster slave node 
> when it processes revisions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to