On 10.2.12 11:00, Ard Schrijvers wrote:
On Fri, Feb 10, 2012 at 11:41 AM, Stefan Guggisberg
<[email protected]> wrote:
On Thu, Feb 9, 2012 at 11:45 PM, Michael Dürig<[email protected]> wrote:
Hi,
I stumbled upon this by chance: The equals method for the classes
ChildNodeEntriesMap and ChildNodeEntry is not symmetric.
hmm, i am pretty sure they're symmetric, i.e.: a.equals(b) == b.equals(a)
They look symmetric to me as well. Unless you refer to the Bucket innerclass
ChildNodeEntriesMap#Bucket : This one has an invalid equals method
breaking symmetry : Using super.equals in an equals implementation
almost always breaks symmetry
Yes, that's what I was referring to actually.
Michael
Regards Ard
or are you referring to the missing hashCode() override?
i admit that i've been lazy since those internal objects are not
intended to be used as keys for hash tables and sorts.
but you're probably right, it doesn't hurt to implement them :)
cheers
stefan
This will most
certainly lead to subtle bugs later on.
Michael
