[
https://issues.apache.org/jira/browse/JCR-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286418#comment-13286418
]
Thomas Mueller commented on JCR-2666:
-------------------------------------
In your patch, you have the following code within the loop:
+ names.add(columnName);
+ assertTrue("Missing column: " + columnName,
names.remove(columnName));
This will add and then remove the column name, leaving "names" empty. I guess
the second line is incorrect?
> JCR TCK Test for Restoring Version Tests That Versionable Child Is also
> Restored, contrary to JCR 2.0 specification
> -------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-2666
> URL: https://issues.apache.org/jira/browse/JCR-2666
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-tests, JCR 2.0
> Affects Versions: 2.1, 2.4.1
> Reporter: Brian Carothers
> Attachments:
> 0001-JCR-2666-Corrected-expectation-for-a-test-in-Restore.patch
>
>
> The test case testRestoreNameJcr2 in o.a.j.test.version.RestoreTest, ends by
> validating that restoring a versionable parent also restores its versionable
> child. This was the correct behavior in JCR 1.0, but was changed in JCR 21].
> The testRestoreName method in the same class correctly notes this and
> changed the behavior for JCR 2.
> This can be corrected by replacing the last 3 lines of testRestoreNameJcr2
> with something analogous to the last 5 lines of testRestoreName.
> Thanks!
> [1] - JCR2 specification, section 15.7.5 - "If the workspace currently has an
> already existing node corresponding to C's version history and the
> removeExisting flag of the restore is set to true, then that instance of C
> becomes the child of the restored N."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
