[
https://issues.apache.org/jira/browse/JCR-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403828#comment-13403828
]
Felix Meschberger commented on JCR-3350:
----------------------------------------
Some comments:
* I would wrap the RepositoryException inside a generic RuntimeException. This
makes handling unduly hard and inside a Jackrabbit class, it is probably
appropriate to have RepositoryExceptions thrown. But those should be documented
* Is it required to check for the existence of the item first ? In other words,
would setting the ACL fail if the item would not exist ? What if the item is a
property ?
* I would get rid of the autoSave flag and just document this method does not
save or rollback at all.
> Easy-to-use utility class for adding ACEs to nodes
> --------------------------------------------------
>
> Key: JCR-3350
> URL: https://issues.apache.org/jira/browse/JCR-3350
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
> Reporter: Jeff Young
> Assignee: angela
> Labels: newbie, patch
> Attachments: AccessControlUtils.java,
> JCR-3350_-_Easy-to-use_utility_class_for_adding_ACEs_to_nodes.patch
>
>
> There should be any easy (one-line) method for adding an ACE to a node in a
> repo supporting resource-based ACLs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
