[
https://issues.apache.org/jira/browse/JCR-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883996#comment-13883996
]
Thomas Mueller commented on JCR-3705:
-------------------------------------
Thanks a lot! The patch moves many classes from jackrabbit-core to
jackrabbit-jcr-commons, I'm not sure if that's the right way to do it.
To get an overview of the changes, here the result of svn patch (sorted; oaj
means org/apache/jackrabbit):
{code}
Added files ------------------------
jackrabbit-data/pom.xml
jackrabbit-data/src/main/java/oaj/core/data/AbstractDataRecord.java
jackrabbit-data/src/main/java/oaj/core/data/AbstractDataStore.java
jackrabbit-data/src/main/java/oaj/core/data/DataIdentifier.java
jackrabbit-data/src/main/java/oaj/core/data/DataRecord.java
jackrabbit-data/src/main/java/oaj/core/data/DataStore.java
jackrabbit-data/src/main/java/oaj/core/data/DataStoreException.java
jackrabbit-data/src/main/java/oaj/core/data/DataStoreFactory.java
jackrabbit-data/src/main/java/oaj/core/data/db/DbDataRecord.java
jackrabbit-data/src/main/java/oaj/core/data/db/DbDataStore.java
jackrabbit-data/src/main/java/oaj/core/data/db/DbInputStream.java
jackrabbit-data/src/main/java/oaj/core/data/db/DerbyDataStore.java
jackrabbit-data/src/main/java/oaj/core/data/FileDataRecord.java
jackrabbit-data/src/main/java/oaj/core/data/FileDataStore.java
jackrabbit-data/src/main/java/oaj/core/data/LazyFileInputStream.java
jackrabbit-data/src/main/java/oaj/core/data/LocalCache.java
jackrabbit-data/src/main/java/oaj/core/data/MultiDataStore.java
jackrabbit-data/src/main/java/oaj/core/data/MultiDataStoreAware.java
jackrabbit-data/src/main/java/oaj/core/data/ScanEventListener.java
jackrabbit-data/src/main/java/oaj/data/cache/Backend.java
jackrabbit-data/src/main/java/oaj/data/cache/CachingDataRecord.java
jackrabbit-data/src/main/java/oaj/data/cache/CachingDataStore.java
jackrabbit-data/src/main/resources/oaj/core/data/db/azure.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/db2.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/derby.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/h2.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/ingres.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/mssql.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/mysql.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/oracle.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/postgresql.properties
jackrabbit-data/src/main/resources/oaj/core/data/db/sqlserver.properties
jackrabbit-jcr-commons/src/main/java/oaj/core/config/ConfigurationException.java
jackrabbit-jcr-commons/src/main/java/oaj/core/config/DataSourceConfig.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/BasedFileSystem.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/FileSystem.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/FileSystemException.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/FileSystemFactory.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/FileSystemPathUtil.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/FileSystemResource.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/local/FileUtil.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/local/HandleMonitor.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/local/LocalFileSystem.java
jackrabbit-jcr-commons/src/main/java/oaj/core/fs/RandomAccessOutputStream.java
jackrabbit-jcr-commons/src/main/java/oaj/core/InternalXAResource.java
jackrabbit-jcr-commons/src/main/java/oaj/core/TransactionContext.java
jackrabbit-jcr-commons/src/main/java/oaj/core/TransactionException.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/CheckSchemaOperation.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/ConnectionFactory.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/ConnectionHelper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/DatabaseAware.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/DataSourceWrapper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/DbUtility.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/DerbyConnectionHelper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/Oracle10R1ConnectionHelper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/OracleConnectionHelper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/PostgreSQLConnectionHelper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/ResultSetWrapper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/StreamWrapper.java
jackrabbit-jcr-commons/src/main/java/oaj/core/util/db/TempFileInputStream.java
Removed files ------------------------
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/ds/Backend.java
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/ds/CachingDataRecord.java
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/ds/CachingDataStore.java
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/LocalCache.java
jackrabbit-core/src/main/java/oaj/core/config/ConfigurationException.java
jackrabbit-core/src/main/java/oaj/core/config/DataSourceConfig.java
jackrabbit-core/src/main/java/oaj/core/data/AbstractDataRecord.java
jackrabbit-core/src/main/java/oaj/core/data/AbstractDataStore.java
jackrabbit-core/src/main/java/oaj/core/data/DataIdentifier.java
jackrabbit-core/src/main/java/oaj/core/data/DataRecord.java
jackrabbit-core/src/main/java/oaj/core/data/DataStore.java
jackrabbit-core/src/main/java/oaj/core/data/DataStoreException.java
jackrabbit-core/src/main/java/oaj/core/data/DataStoreFactory.java
jackrabbit-core/src/main/java/oaj/core/data/db/DbDataRecord.java
jackrabbit-core/src/main/java/oaj/core/data/db/DbDataStore.java
jackrabbit-core/src/main/java/oaj/core/data/db/DbInputStream.java
jackrabbit-core/src/main/java/oaj/core/data/db/DerbyDataStore.java
jackrabbit-core/src/main/java/oaj/core/data/db/TempFileInputStream.java
jackrabbit-core/src/main/java/oaj/core/data/FileDataRecord.java
jackrabbit-core/src/main/java/oaj/core/data/FileDataStore.java
jackrabbit-core/src/main/java/oaj/core/data/LazyFileInputStream.java
jackrabbit-core/src/main/java/oaj/core/data/MultiDataStore.java
jackrabbit-core/src/main/java/oaj/core/data/MultiDataStoreAware.java
jackrabbit-core/src/main/java/oaj/core/data/ScanEventListener.java
jackrabbit-core/src/main/java/oaj/core/fs/BasedFileSystem.java
jackrabbit-core/src/main/java/oaj/core/fs/FileSystem.java
jackrabbit-core/src/main/java/oaj/core/fs/FileSystemException.java
jackrabbit-core/src/main/java/oaj/core/fs/FileSystemFactory.java
jackrabbit-core/src/main/java/oaj/core/fs/FileSystemPathUtil.java
jackrabbit-core/src/main/java/oaj/core/fs/FileSystemResource.java
jackrabbit-core/src/main/java/oaj/core/fs/local/FileUtil.java
jackrabbit-core/src/main/java/oaj/core/fs/local/HandleMonitor.java
jackrabbit-core/src/main/java/oaj/core/fs/local/LocalFileSystem.java
jackrabbit-core/src/main/java/oaj/core/fs/RandomAccessOutputStream.java
jackrabbit-core/src/main/java/oaj/core/InternalXAResource.java
jackrabbit-core/src/main/java/oaj/core/TransactionContext.java
jackrabbit-core/src/main/java/oaj/core/TransactionException.java
jackrabbit-core/src/main/java/oaj/core/util/db/CheckSchemaOperation.java
jackrabbit-core/src/main/java/oaj/core/util/db/ConnectionFactory.java
jackrabbit-core/src/main/java/oaj/core/util/db/ConnectionHelper.java
jackrabbit-core/src/main/java/oaj/core/util/db/DatabaseAware.java
jackrabbit-core/src/main/java/oaj/core/util/db/DataSourceWrapper.java
jackrabbit-core/src/main/java/oaj/core/util/db/DbUtility.java
jackrabbit-core/src/main/java/oaj/core/util/db/DerbyConnectionHelper.java
jackrabbit-core/src/main/java/oaj/core/util/db/Oracle10R1ConnectionHelper.java
jackrabbit-core/src/main/java/oaj/core/util/db/OracleConnectionHelper.java
jackrabbit-core/src/main/java/oaj/core/util/db/PostgreSQLConnectionHelper.java
jackrabbit-core/src/main/java/oaj/core/util/db/ResultSetWrapper.java
jackrabbit-core/src/main/java/oaj/core/util/db/StreamWrapper.java
jackrabbit-core/src/main/resources/oaj/core/data/db/azure.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/db2.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/derby.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/h2.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/ingres.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/mssql.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/mysql.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/oracle.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/postgresql.properties
jackrabbit-core/src/main/resources/oaj/core/data/db/sqlserver.properties
Changed files ------------------------
jackrabbit-aws-ext/pom.xml
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/ds/S3Backend.java
jackrabbit-aws-ext/src/main/java/oaj/aws/ext/ds/S3DataStore.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/InMemoryBackend.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/InMemoryDataStore.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/TestCaseBase.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/TestInMemDs.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/TestInMemDsCacheOff.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/TestS3Ds.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/ds/TestS3DsCacheOff.java
jackrabbit-aws-ext/src/test/java/oaj/aws/ext/TestLocalCache.java
jackrabbit-core/pom.xml
jackrabbit-core/src/test/java/oaj/core/data/TempFileInputStreamTest.java
jackrabbit-jcr-commons/pom.xml
pom.xml
{code}
> Extract data store API and implementations from jackrabbit-core
> ---------------------------------------------------------------
>
> Key: JCR-3705
> URL: https://issues.apache.org/jira/browse/JCR-3705
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Jukka Zitting
> Labels: patch
> Attachments: JCR-3705.patch
>
>
> In Oak we'd like to use the Jackrabbit data stores (OAK-805). Doing so would
> currently require a direct dependency to jackrabbit-core, which is
> troublesome for various reasons.
> Since the DataStore interface and its implementations are mostly independent
> of the rest of Jackrabbit internals, it should be possible to avoid that
> dependency by moving the data store bits to some other component.
> One alternative would be to place them in jackrabbit-jcr-commons, another to
> create a separate new jackrabbit-data component for this purpose. WDYT?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
