[ 
https://issues.apache.org/jira/browse/JCR-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933167#comment-13933167
 ] 

Felix Meschberger commented on JCR-3745:
----------------------------------------

[~rombert] I think we can just keep both methods and should be fine.

[~mduerig] I seem to understand we agree on the setter methods for interfaces: 
How about defining JackrabbitEventListener as a final class ? 

(NB: Actually it just occurrs to me why setters on interfaces are a really bad 
idea: This basically defines a mutable object and so the filter used for 
registration cannot be used by the ObservationManager essentially causing the 
latter to clone (or otherwise copy) the settings for internal use. Slightly 
better would be a builder interface with setters and the actual interface with 
getters -- still two objects, though ...)

> Add JackrabbitObservationManager with additional methods for registering 
> event listeners
> ----------------------------------------------------------------------------------------
>
>                 Key: JCR-3745
>                 URL: https://issues.apache.org/jira/browse/JCR-3745
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-api
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>         Attachments: JCR-3745.patch
>
>
> I'd like to add an additional method for adding event listeners to the 
> Jackrabbit API: 
> void addEventListener(EventListener listener, int eventTypes, String[] 
> absPaths, boolean isDeep, String[] uuid, String[] nodeTypeName, boolean 
> noLocal, boolean noExternal) throws RepositoryException; 
> Compared to the JCR method of the same name, this method takes an array of 
> absPath and additional boolean argument: 
> Only events whose associated parent node is at one of the paths in 
> <code>absPaths</code> (or within its subgraph, if <code>isDeep</code> is 
> <code>true</code>) will be received. 
> and 
> Additionally, if <code>noExternal</code> is <code>true</code>, then events 
> from external cluster nodes are ignored. Otherwise, they are not ignored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to